From 3a37732617528070bfa1df7b15b3fbc7c8143e41 Mon Sep 17 00:00:00 2001 From: Tat Dat Duong Date: Wed, 23 Oct 2024 01:09:15 +0200 Subject: [PATCH] Remove the type dependency --- js/package.json | 1 - js/src/wrappers/vercel/exporter.ts | 12 ++++++------ js/yarn.lock | 2 +- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/js/package.json b/js/package.json index 0e64b4e93..488285d6a 100644 --- a/js/package.json +++ b/js/package.json @@ -112,7 +112,6 @@ "@langchain/core": "^0.3.1", "@langchain/langgraph": "^0.2.3", "@langchain/openai": "^0.3.0", - "@opentelemetry/api": "^1.9.0", "@opentelemetry/sdk-trace-base": "^1.26.0", "@opentelemetry/sdk-trace-node": "^1.26.0", "@tsconfig/recommended": "^1.0.2", diff --git a/js/src/wrappers/vercel/exporter.ts b/js/src/wrappers/vercel/exporter.ts index 7a7741557..6cd46b2a6 100644 --- a/js/src/wrappers/vercel/exporter.ts +++ b/js/src/wrappers/vercel/exporter.ts @@ -1,5 +1,4 @@ -import type { ReadableSpan, SpanExporter } from "@opentelemetry/sdk-trace-base"; -import type { ExportResult } from "@opentelemetry/core"; +import type { ReadableSpan } from "@opentelemetry/sdk-trace-base"; import type { CoreAssistantMessage, CoreMessage, ToolCallPart } from "ai"; import type { AISDKSpan } from "./exporter.types.js"; import { Client } from "../../index.js"; @@ -212,7 +211,7 @@ interface RunTask { executionOrder: number; } -export class LangSmithAISDKExporter implements SpanExporter { +export class LangSmithAISDKExporter { private client: Client; private traceByMap: Record< string, @@ -475,10 +474,11 @@ export class LangSmithAISDKExporter implements SpanExporter { } export( - spans: ReadableSpan[], - resultCallback: (result: ExportResult) => void + spans: unknown[], + resultCallback: (result: { code: 0 | 1; error?: Error }) => void ): void { - for (const span of spans) { + const typedSpans = spans as ReadableSpan[]; + for (const span of typedSpans) { const { traceId, spanId } = span.spanContext(); const parentId = span.parentSpanId ?? undefined; this.traceByMap[traceId] ??= { diff --git a/js/yarn.lock b/js/yarn.lock index 31411bc6d..bf35ed96d 100644 --- a/js/yarn.lock +++ b/js/yarn.lock @@ -1443,7 +1443,7 @@ "@nodelib/fs.scandir" "2.1.5" fastq "^1.6.0" -"@opentelemetry/api@1.9.0", "@opentelemetry/api@^1.9.0": +"@opentelemetry/api@1.9.0": version "1.9.0" resolved "https://registry.yarnpkg.com/@opentelemetry/api/-/api-1.9.0.tgz#d03eba68273dc0f7509e2a3d5cba21eae10379fe" integrity sha512-3giAOQvZiH5F9bMlMiv8+GSPMeqg0dbaeo58/0SlA9sxSqZhnUtxzX9/2FzyhS9sWQf5S0GJE0AKBrFqjpeYcg==