From 697bf39d210fa87be4b84f6f3883023bde0a8d2a Mon Sep 17 00:00:00 2001 From: jacoblee93 Date: Tue, 10 Dec 2024 20:36:15 -0800 Subject: [PATCH] Tone down TODO --- js/src/tests/evaluate_attachments.int.test.ts | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/js/src/tests/evaluate_attachments.int.test.ts b/js/src/tests/evaluate_attachments.int.test.ts index 20112d57f..9a78a3f9a 100644 --- a/js/src/tests/evaluate_attachments.int.test.ts +++ b/js/src/tests/evaluate_attachments.int.test.ts @@ -93,8 +93,7 @@ test("evaluate can handle examples with attachments", async () => { expect(evalRes.results).toHaveLength(2); for (const result of evalRes.results) { - // NOTE: THIS DOES NOT WORK YET BECAUSE THE ATTACHMENTS ARE NOT TRACED CORRECTLY - // THIS SHOULD BE FIXED ASAP + // TODO: Uncomment when attachments are traced correctly // expect(result.run.attachments).toBeDefined(); expect(result.run).toBeDefined(); expect(result.example).toBeDefined(); @@ -172,8 +171,7 @@ test("evaluate with attachments not in target function", async () => { expect(evalRes.results).toHaveLength(2); for (const result of evalRes.results) { - // NOTE: THIS DOES NOT WORK YET BECAUSE THE ATTACHMENTS ARE NOT TRACED CORRECTLY - // THIS SHOULD BE FIXED ASAP + // TODO: Uncomment when attachments are traced correctly // expect(result.run.attachments).toBeDefined(); expect(result.run).toBeDefined(); expect(result.example).toBeDefined(); @@ -297,8 +295,7 @@ test("multiple evaluators with attachments", async () => { expect(evalRes.results).toHaveLength(2); for (const result of evalRes.results) { - // NOTE: THIS DOES NOT WORK YET BECAUSE THE ATTACHMENTS ARE NOT TRACED CORRECTLY - // THIS SHOULD BE FIXED ASAP + // TODO: Uncomment when attachments are traced correctly // expect(result.run.attachments).toBeDefined(); expect(result.run).toBeDefined(); expect(result.example).toBeDefined(); @@ -398,8 +395,7 @@ test("evaluate with attachments runnable target function", async () => { expect(evalRes.results).toHaveLength(2); for (const result of evalRes.results) { - // NOTE: THIS DOES NOT WORK YET BECAUSE THE ATTACHMENTS ARE NOT TRACED CORRECTLY - // THIS SHOULD BE FIXED ASAP + // TODO: Uncomment when attachments are traced correctly // expect(result.run.attachments).toBeDefined(); expect(result.run).toBeDefined(); expect(result.example).toBeDefined();