Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings config for temperature, max tokens #149

Open
bracesproul opened this issue Oct 28, 2024 · 4 comments · May be fixed by #176
Open

Add settings config for temperature, max tokens #149

bracesproul opened this issue Oct 28, 2024 · 4 comments · May be fixed by #176
Assignees
@ahmad2b
Labels
ai fullstack

Comments

@bracesproul
Copy link
Member

Max tokens should have a dynamic slider based on the model selected and its token output range. Temperature should also be a slider, allowing 0-1 (or 0-2 if the model supports)

It should have a nice, non technical description describing what each field will do.

These fields should be passed through configurable like we what do with the model name.

The max tokens field should apply to all nodes which update/rewrite artifacts. It should not apply to the router or followup nodes.
@ahmad2b
Copy link
Contributor

ahmad2b commented Oct 30, 2024

Hey @bracesproul,

I appreciate your detailed suggestions! I'm eager to take on this issue and start working on adding the settings configuration for temperature and max tokens. It looks like this is tied to the model customization feature that’s currently in the staging branch.

Should I proceed with creating the PR in the staging branch, or would you prefer I wait until it’s released in the main branch?

Looking forward to your guidance!

Sincerely,
Ahmad

@bracesproul
Copy link
Member Author

@ahmad2b planning on releasing staging today, so let's hold off until that gets merged in before working on this. I'll assign it to you in the meantime

@ahmad2b
Copy link
Contributor

ahmad2b commented Oct 30, 2024

Thanks for the update, @bracesproul! I appreciate the assignment. I’ll hold off until then. I’m excited to dive in once we’re ready!

@bracesproul
Copy link
Member Author

@ahmad2b you're all set to start on this now

ahmad2b added a commit to ahmad2b/open-canvas that referenced this issue Nov 4, 2024
@ahmad2b
feat: add model temperature and max tokens config (langchain-ai#149)
e1b358b
@ahmad2b ahmad2b linked a pull request Nov 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmad2b ahmad2b

Labels
ai fullstack
Projects
Open Canvas Feature Roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #149: Add Temperature and Max Tokens Configuration ahmad2b/open-canvas
2 participants
@bracesproul @ahmad2b