Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (30e3d39) to head (a7190d8).
Report is 4 commits behind head on master.

@@            Coverage Diff             @@
##           master     #934      +/-   ##
==========================================
- Coverage   94.06%   93.57%   -0.50%     
==========================================
  Files          43       42       -1     
  Lines        9665     9627      -38     
==========================================
- Hits         9091     9008      -83     
- Misses        574      619      +45     

@ccoffrin can you review this please?

Sorry for the delay @KSepetanc. I have no way of verifying these semantics of PSSE. @jd-lara or @frederikgeth are you able to verify this behavior?

@KSepetanc, before merging we will need to add a test for this behavior so that we don't have a future regression.

not able to verify, sorry, but can confirm he actual status of a machine is determined both by its status flag and the bus type code.

@ccoffrin I can not find any network in the PowerModels test/data/pti that has generator placed at load bus. I am not very comfortable modifying those frankenstein networks (presumably frankenstein_70.raw) as I do not know repercussions on other tests. I will need help with this.

test construct should be something like this (in test/psse.jl after transformer status tests):

    @testset "generator status" begin
        data_pti = PowerModels.parse_file("../test/data/pti/frankenstein_70.raw")

        gen_off = Set(["8", "9"]) # put names of inactive gens here
        for (i,gen) in data_pti["gen"]
            if i in gen_off
                @test gen["gen_status"] == 0
            else
                @test gen["gen_status"] == 1
            end
        end
    end

I have modified frankenstein_70.raw at but 1005 to load bus. Test has been added.

Do you think we need to add memento log in src/io/psse.jl line 214 for the case when bus type is 1 and gen["STAT"] is 1?

@ccoffrin do you have someone else who can check this? I would like to close this issue soon.

There is free trial version of PSSE with full computation support for up-to 50 buses. Can that help with the review?