Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation error opens on the wrong accordion item #14

Open
ronssij opened this issue Dec 3, 2024 · 4 comments
Open

Validation error opens on the wrong accordion item #14

ronssij opened this issue Dec 3, 2024 · 4 comments

Comments

@ronssij
Copy link

ronssij commented Dec 3, 2024

It shows on the wrong accordion item.
image

When validating forms it should open on the correct accordion item like the filaments tab item do on showing validation errors.

image

@atmonshi
Copy link
Member

sorry for the delay.

dose it open on the first accordion that has error?? I think its the same behavior as filament tabs.

if you can share simple code to reproduce it, I appreciate it. feel free to reopen.

@ronssij
Copy link
Author

ronssij commented Jan 7, 2025

@atmonshi

I can't have a sample for now but I will attach the screen recording.
base on my example about out should open the first accordion item (same with filament tabs) but what happen is it randomly opens randomly or the last item where the error occurs.

CleanShot 2025-01-07 at 15 37 23

@atmonshi
Copy link
Member

if you can debug it on the file:
resources/views/components/accordion/item.blade.php
any console errors?

I am using x-on:form-validation-error.window the same as filament tabs too.

also I did small update, not sure if its relative #16

@atmonshi atmonshi reopened this Jan 13, 2025
@ronssij
Copy link
Author

ronssij commented Jan 22, 2025

@atmonshi I think #16 fixed the issue when validated, but doesn't get back to the first accordion where an error occurs.

This works for now, Will try my best debug this on the pacakge level and will try my best to contribute on this package too on my free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants