Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Non-Obvious Failed Validation on Form Options #303

Closed
blhylton opened this issue Jun 10, 2024 · 1 comment · Fixed by lara-zeus/accordion#11
Closed

[Bug]: Non-Obvious Failed Validation on Form Options #303

blhylton opened this issue Jun 10, 2024 · 1 comment · Fixed by lara-zeus/accordion#11
Labels
bug Something isn't working

Comments

@blhylton
Copy link

blhylton commented Jun 10, 2024

What happened?

If you edit a form field's options and there is a validation issue, but the accordion is not expanded for that particular option, it's not apparent that it failed validation.


Validation error with closed accordion


Validation error with open accordion


These screenshots were taken in order, the only difference being that the Accordion was open in the second one.

How to reproduce the bug

The images above tell the story fairly well, but to spell it out in detail:

  1. Open field options.
  2. Enter options that do not fit validation. The easiest one I found is leaving the "Data Validation" field blank on TextInput.
  3. Collapse all Accordions or open a different Accordion than the one you know has the validation issue.
  4. Submit options modal form.

Modal won't close, so it's obvious that something errored, but it's difficult to tell what without expanding the Accordion(s).

Package Version

3.0.52

PHP Version

8.2.19

Laravel Version

11.10.0

Which operating systems does with happen with?

macOS

Notes

This was truthfully reproduced on the custom-schema branch, but it is up to date with the 3.x branch, and I don't see any reason why this feature branch would impact this aspect of the UI.

I'm unfamiliar with the Accordion internals, but it should be as "simple" as bubbling up the error to highlight the section and indicate an error inside.

Edit: Added some horizontal lines around the images. They were bleeding together, making it hard to see which was which.

@atmonshi
Copy link
Member

hopefully this will fix the issue, just do a composer update and check :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants