Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal doesn't focus keyboard #5992

Closed
leigeber opened this issue Oct 26, 2023 · 5 comments
Closed

Modal doesn't focus keyboard #5992

leigeber opened this issue Oct 26, 2023 · 5 comments
Labels
bug Verified bug by the Nova team

Comments

@leigeber
Copy link

  • Laravel Version: 10.29.0
  • Nova Version: 4.28.0
  • PHP Version: 8.2.7
  • Database Driver & Version: PostgreSQL 16
  • Browser type and version: Chrome 117

It seems with the latest release, keyboard accessibility for modals has regressed. Previously when you opened an action modal the modal received focus but that isn't the case anymore. Now the focus remains on whatever you clicked to prompt the action.

@leigeber leigeber changed the title Modal Keyboard Focus Modal doesn't focus keyboard Oct 26, 2023
@crynobone
Copy link
Member

Please provide full reproducing repository based on fresh installation as suggested in the bug report template (or you can refer to https://github.com/nova-issues for example)

@crynobone crynobone added the needs more info More information is required label Oct 26, 2023
@mikkellindblom
Copy link

@crynobone somewhere between release 4.27.14 and the latest release. Autofocus on the first form field in a modal prompt has been removed.

@MPaap
Copy link

MPaap commented Nov 29, 2023

Same issue here, would save allot of time if its reverted back.

afbeelding

afbeelding

It used to focus on the top item, it no longer does that, so pressing enter to submit the form or instantly start making changes no longer works.

@davidhemphill davidhemphill added bug Verified bug by the Nova team and removed needs more info More information is required labels Nov 29, 2023
@davidhemphill
Copy link
Contributor

I believe this issue should be fixed in the latest release. Please post a new issue if the issue persists.

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified bug by the Nova team
Projects
None yet
Development

No branches or pull requests

5 participants