Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor tag for 'View' and 'Edit' button does not have the href attribute set #6083

Closed
JaredPage opened this issue Dec 4, 2023 · 7 comments
Closed
Labels
bug Verified bug by the Nova team fix incoming A fix is in review
Milestone

Comments

@JaredPage
Copy link

  • Laravel Version: ^10
  • Nova Version: All versions from v4.29.3 onward.
  • PHP Version: ^8.2
  • Database Driver & Version: MySQL 8.0.27
  • Operating System and Version: On both MacOS and Ubuntu
  • Browser type and version: Browser doesn't affect results.

Description:

All of the 'edit' links in a resource have a null 'href' value from version 4.29.3 onward. See pictures below. When the edit or view buttons are hovered over (or you just inspect source), you will see that the href value for the anchor tag is blank/null from 4.29.3 onward. This results in the 'edit' and 'view' buttons being unable to be opened in a new tab (right-click, open in new tab) and/or using the middle mouse button for the same purpose.

There is also weird behaviour where the initial request is then cancelled, and a subsequent XHR request is made to the correct URL. For the earlier version, this cancelled request includes the <id>/edit portion of the URL, whereas in the newer one, it omits it.

Detailed steps to reproduce the issue on a fresh Nova installation:

  • Install v4.29.2
  • Install v4.29.3 or any version afterwards and notice that every resource does not have the correct link associated with it for the 'Edit' or 'View' buttons.

1  id-present (4 29 2)
2  no-id-present (4 29 3)
cancelled-behaviour-2
cancelled-behaviour-1

@MPaap
Copy link

MPaap commented Dec 7, 2023

Same issue

@vDk3
Copy link

vDk3 commented Dec 11, 2023

+1 very annoying

@andypooletrioteca
Copy link

Already opened an issue related to this and has been closed... Weird decision.

#6075

@JaredPage
Copy link
Author

Already opened an issue related to this and has been closed... Weird decision.

#6075

Oh no....

@anditsung
Copy link

#6126

looks like this issue causing 2 new tab when click using ctrl / command

@jesse-davis
Copy link

Would appreciate a fix for this one.

@crynobone crynobone added the bug Verified bug by the Nova team label Feb 12, 2024
@crynobone crynobone added this to the 4.x milestone Feb 14, 2024
@crynobone crynobone added the fix incoming A fix is in review label Feb 19, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified bug by the Nova team fix incoming A fix is in review
Projects
None yet
Development

No branches or pull requests

7 participants