Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select component in Actions is slow to show results #6107

Closed
meyer59 opened this issue Dec 13, 2023 · 12 comments
Closed

Select component in Actions is slow to show results #6107

meyer59 opened this issue Dec 13, 2023 · 12 comments
Assignees
Labels
bug Verified bug by the Nova team fix incoming A fix is in review

Comments

@meyer59
Copy link

meyer59 commented Dec 13, 2023

  • Laravel Version: 10.37.3
  • Nova Version: 4.32.9
  • PHP Version: 8.2
  • Database Driver & Version: MYSQL
  • Operating System and Version: UNIX
  • Browser type and version: chrome 119.0.6045.124

Description:

We have noticed an issue with the Select component in our Actions; it doesn't seem to be working properly after the latest update of Nova. The issue manifests as a significant lag in the visual response, giving the impression of extensive processing taking place in the background. This behavior started occurring since the most recent update of Nova.
This is very annonying since the Select component is used everywhere in the app.
Here is a screenshot of the console, the last log appears once i open the Select
image

Detailed steps to reproduce the issue on a fresh Nova installation:

put a searchable select in an action and try to open it

@henryavila
Copy link

The but was introduced in v4.32.7, sol, downgrading to v4.32.6 will work

@meyer59
Copy link
Author

meyer59 commented Dec 14, 2023

(Don't tag maintainers) is there any way to prioritize this bug? It seems to be affecting all of the Nova Select components.

@davidhemphill davidhemphill changed the title Select does'nt work anymore Select component in Actions is slow to show results Dec 15, 2023
@crynobone crynobone added the pending Issues that are pending triage label Feb 12, 2024
@crynobone
Copy link
Member

Please check if the latest version (4.32.15) still has this issue.

@crynobone crynobone added the needs more info More information is required label Feb 27, 2024
@meyer59
Copy link
Author

meyer59 commented Feb 28, 2024

yes it's better but we cannot close the Select.
Also can you remove the Console pollution ? There are plenty of plugin with webpack/vite to remove them in prod build
Thanks
image

@crynobone
Copy link
Member

yes it's better but we cannot close the Select.

Please provide video of this.

@meyer59
Copy link
Author

meyer59 commented Feb 28, 2024

screen-capture.11.mp4

@crynobone
Copy link
Member

CleanShot 2024-02-28 at 10 34 27

@meyer59
Copy link
Author

meyer59 commented Feb 28, 2024

That's weird. can you check now with an mp4 file.

@crynobone
Copy link
Member

image

This code was removed on v4.32.10, are you sure you're on the latest version?

@crynobone crynobone removed the pending Issues that are pending triage label Feb 28, 2024
@meyer59
Copy link
Author

meyer59 commented Feb 28, 2024

My bad, i forgot the nova:publish command. Now the console is cleared but the Select still doesn't close, as shown in the video.

@crynobone crynobone added bug Verified bug by the Nova team and removed needs more info More information is required labels Feb 28, 2024
@crynobone crynobone self-assigned this Feb 28, 2024
@crynobone crynobone added the fix incoming A fix is in review label Mar 5, 2024
@meyer59
Copy link
Author

meyer59 commented Mar 6, 2024

Hey
I don't know if it's related to the fix but the Select doesn't work anymore.
Keeps open, cannot select a value nor search.
Nova v.4.32.16

image

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified bug by the Nova team fix incoming A fix is in review
Projects
None yet
Development

No branches or pull requests

3 participants