Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when exporting resources with a slash/backslash in the filename #6185

Closed
paulandroshchuk opened this issue Feb 7, 2024 · 1 comment
Labels
bug Verified bug by the Nova team
Milestone

Comments

@paulandroshchuk
Copy link

paulandroshchuk commented Feb 7, 2024

  • Laravel Version: 10.43.0
  • Nova Version: 4.32.11
  • PHP Version: 8.2.3

Description:

Noticed an issue with the CSV Export built-in action. When the name of the file has a slash or a backslash, it throws the following exception:

The filename and the fallback cannot contain the "/" and "\" characters.

If that's intended, could validation be added to that field at least? It just silently fails (no errors on the frontend, it just keeps the modal open) and you have no idea why until you manually find the error in laravel.log.

Detailed steps to reproduce the issue on a fresh Nova installation:

  1. Create a Nova resource
  2. Add CSVExport action to the resource
  3. Try to export it with a slash/backslash in the filename

CleanShot 2024-02-07 at 20 03 32@2x

@crynobone crynobone added the bug Verified bug by the Nova team label Feb 12, 2024
@crynobone crynobone added this to the 4.x milestone Feb 13, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified bug by the Nova team
Projects
None yet
Development

No branches or pull requests

2 participants