Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search input not working in select field for actions #6276

Closed
guybrun opened this issue Mar 13, 2024 · 14 comments
Closed

Search input not working in select field for actions #6276

guybrun opened this issue Mar 13, 2024 · 14 comments
Labels
bug Verified bug by the Nova team fix incoming A fix is in review

Comments

@guybrun
Copy link

guybrun commented Mar 13, 2024

  • Laravel Version: 10.48.2
  • Nova Version: 4.32.16
  • PHP Version: 8.2.7
  • Database Driver & Version:
  • Operating System and Version: Debian 6.1.76-1 (2024-02-01) x86_64 GNU/Linux
  • Browser type and version: Chrome.122.0.6261.129 (Official Build) (64-bit)

Description:

Updated to Nova version 4.32.16 and discovered that the search input field does not work for select field which is searchable() in actions,

It is not possible to type in the Search input field.

Take a look at uploaded screenshot.
nova-4-32-16-bug

Detailed steps to reproduce the issue on a fresh Nova installation:

@crynobone
Copy link
Member

Fixed in 4.33.0

@skywalker666
Copy link

Well, it still doesn't work for any searchable select field in an action. For the first one it's always opened by default (like shown in the screenshot above) and there seems to be some weird interaction with a second one when that gets opened.

@guybrun
Copy link
Author

guybrun commented Mar 13, 2024

Fixed in 4.33.0
I updated to 4.33.0, but still same issue

@crynobone crynobone reopened this Mar 13, 2024
@potsky
Copy link

potsky commented Mar 13, 2024

Same problem and behavior.
#6257 has fixed the global freeze but not the belongsTo freeze

@meyer59
Copy link

meyer59 commented Mar 13, 2024

i have opened the same issues Dec 13 and reopen one a few days ago. How arogant they are, they keep closing my issues but the problem is still here #6271 #6107

@potsky
Copy link

potsky commented Mar 13, 2024

i have opened the same issues Dec 13 and reopen one a few days ago. How arogant they are, they keep closing my issues but the problem is still here #6271 #6107

Arogant I don't know, but bugs are part of the development process 😇 Even if we pay for Nova, there will always be some bugs. This is normal.

We just need to be constructive to help them to find and fix bugs. I know this is annoying, my sales team of 10 people is currently blocked due to this bug, they cannot import electrical powers and consumption of French companies but we can just wait for the Nova team to fix the problem.

The actual bug is a common regression in Nova on BelongsTo fields. It was already the case on December #6113 then after it works agains and finally not!

In #6097 @davidhemphill said #6097 (comment)

It seems the previous fix was just a strap...

@animena
Copy link

animena commented Mar 14, 2024

same issue here, and blocking me from deadline, looks like I have to modify the code until this one is fixed

@goldmerc
Copy link

  • 1, updating to 4.33.0 doesn't fix the issue. Non searchable selects work fine but searchable ones start expanded and don't allow me to make a selection. I have to tab out or press escape.

@puzzledmonkey
Copy link

same issue here.

honestly, sorry to bring this up as i'm sure everyone agrees, but if this has been an issue since 4.32.16, why is it not already in your dusk test cases - specifically the "BelongsTo searchable in an Action popup" case that STILL causes this issue on 4.33.0?

it's quite frustrating that we cannot rely on simple functionality like this in a paid product such as Nova.

@mostafaznv
Copy link

mostafaznv commented Mar 17, 2024

I believe this issue is related to #6242
I reported it a couple of days ago, and while they released some fixes, the problem persists.

Please refer to that issue for a detailed explanation, including a reproduction repository and a video demonstrating the problem.

Edit: it doesn't work with 4.33.0 either

@crynobone crynobone added bug Verified bug by the Nova team fix incoming A fix is in review labels Mar 18, 2024
@SamMakesCode
Copy link

Sorry, I'm confused. I'm sure something similar was fixed in v4.33.0 but almost almost unanimously people here are saying this particular issue isn't fixed.

@crynobone has marked this as fix incoming, does that means there's a fix coming in v4.33.1?

I'm running v4.33.0 and am unable to focus on the search field when using searchable on the Select nova field type. I can also confirm this issue doesn't occur in v4.32.11

@potsky
Copy link

potsky commented Mar 21, 2024

Sorry, I'm confused. I'm sure something similar was fixed in v4.33.0 but almost almost unanimously people here are saying this particular issue isn't fixed.

@crynobone has marked this as fix incoming, does that means there's a fix coming in v4.33.1?

I'm running v4.33.0 and am unable to focus on the search field when using searchable on the Select nova field type. I can also confirm this issue doesn't occur in v4.32.11

This is not fixed in v4.33.0 We certainly have to wait for the next version.

@puzzledmonkey
Copy link

Hey @crynobone or @davidhemphill is there any ETA on getting this fix released? You've previously released point releases with single bug fixes, and this issue is really breaking functionality. Is there any chance of making a point release to fix this issue in particular?

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified bug by the Nova team fix incoming A fix is in review
Projects
None yet
Development

No branches or pull requests

10 participants