Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple 'canRun' callbacks are not repecting truthy states #6466

Closed
jonnigg opened this issue Jul 18, 2024 · 2 comments
Closed

Multiple 'canRun' callbacks are not repecting truthy states #6466

jonnigg opened this issue Jul 18, 2024 · 2 comments
Labels
bug Verified bug by the Nova team fix incoming A fix is in review
Milestone

Comments

@jonnigg
Copy link

jonnigg commented Jul 18, 2024

  • Laravel Version: ^8.78
  • Nova Version: 4.34.3
  • PHP Version: ^8.0
  • Database Driver & Version: PostgreSql 11
  • Operating System and Version: MacOS 14.5
  • Browser type and version: Firefox 128.0

Description:

This issue is exactly the same issue as Issue 6124 where it was indicated that it was fixed--though it appears to be unresolved. When returning multiple canRun callback functions, when one canRun function returns false, any subsequent callback functions return true regardless of their actual truthy value. In short, I can not have two + N callback functions return false.

Detailed steps to reproduce the issue on a fresh Nova installation:

Return two canRun functions as false

image

image

Return one true one false

image

image

Return one true one false
image

image

@jonnigg
Copy link
Author

jonnigg commented Jul 18, 2024

This seems to be specific to the actions dropdown menu that appears when performing the check box selection. Inline and the details page seems to respect the truthy values as expected.

@crynobone crynobone added bug Verified bug by the Nova team fix incoming A fix is in review labels Jul 19, 2024
@crynobone crynobone added this to the 4.x milestone Jul 23, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified bug by the Nova team fix incoming A fix is in review
Projects
None yet
Development

No branches or pull requests

2 participants