Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible Panel as first field won't collapse #6602

Closed
ekateiva opened this issue Dec 11, 2024 · 1 comment
Closed

Collapsible Panel as first field won't collapse #6602

ekateiva opened this issue Dec 11, 2024 · 1 comment
Labels
Milestone

Comments

@ekateiva
Copy link

  • Laravel Version: 11.30.0
  • Nova Version: v4.35.4
  • PHP Version: 8.3.9
  • Database Driver & Version: MySQL
  • Operating System and Version: macOS 14.4
  • Browser type and version: Chrome 130.0.6723.92
  • Reproduction Repository: N/a

Description:

When you define a Panel::make(...)->collapsable() as the first fields() element, it is not collapsable and the arrow is not even seen.

image

Detailed steps to reproduce the issue on a fresh Nova installation:

public function fields(NovaRequest $request)
{
        return [
            Panel::make('First Panel', [
                // Fields
            ])
            ->collapsable(),
            // ...
            // Other fields
        ];
}

Related issue

#4749

@crynobone crynobone added this to the 5.1.x milestone Dec 18, 2024
@crynobone crynobone added pending Issues that are pending triage blocked labels Dec 19, 2024
@crynobone crynobone removed this from the 5.1.x milestone Dec 23, 2024
@crynobone
Copy link
Member

After much consideration, we are not going to change the behavior here. You can create an empty panel to cover the use case. In future versions, we will add a deprecation warning if you attempt to use it as the first panel and throw an exception in Nova 6.

@crynobone crynobone added this to the 5.1.x milestone Dec 27, 2024
@crynobone crynobone removed the pending Issues that are pending triage label Dec 30, 2024
@laravel laravel locked and limited conversation to collaborators Jan 2, 2025
@crynobone crynobone converted this issue into discussion #6646 Jan 2, 2025

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
Projects
None yet
Development

No branches or pull requests

2 participants