Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trend Metrics format function doesn't accept arrays #6637

Closed
niekdemelker opened this issue Dec 26, 2024 · 1 comment
Closed

Trend Metrics format function doesn't accept arrays #6637

niekdemelker opened this issue Dec 26, 2024 · 1 comment
Labels
bug Verified bug by the Nova team fix incoming A fix is in review
Milestone

Comments

@niekdemelker
Copy link

  • Laravel Version: 11.36.1
  • Nova Version: 5.0.6
  • PHP Version: 8.3.15

Description:

The formatting for trends don't accept arrays, but the documentation provides this as an option, see: https://nova.laravel.com/docs/v5/metrics/defining-metrics#displaying-the-current-value

I also noticed the type hinting for Progress isn't specified at all, these should all be array|string I think.

The example in question:

    return $this->count($request, User::class)
                ->format([
                    'thousandSeparated' => true,
                    'mantissa' => 2,
                ]);

afbeelding

@crynobone crynobone added bug Verified bug by the Nova team fix incoming A fix is in review labels Dec 27, 2024
@crynobone crynobone added this to the 5.0.x milestone Dec 27, 2024
Copy link

github-actions bot commented Jan 2, 2025

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified bug by the Nova team fix incoming A fix is in review
Projects
None yet
Development

No branches or pull requests

2 participants