Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled carriage return as 'Enter' #176

Closed
Carnicero90 opened this issue Nov 19, 2024 · 5 comments
Closed

Unhandled carriage return as 'Enter' #176

Carnicero90 opened this issue Nov 19, 2024 · 5 comments

Comments

@Carnicero90
Copy link

Laravel Prompts Version

0.3.2

Laravel Version

11.31.0

PHP Version

8.3.3

Operating System & Version

macOS 14.5

Terminal Application

alacritty, builtin vscode terminal, etc

Description

Whenever my terminal doesn't convert carriage return to new line (not sure why taht's happening, it seems to be caused by prompts though, for whatever reason), I am unable to submit any prompt, since \r isn't handled.

I think you could either add icrnl in Terminal@setTty or submit on $key == Key::CARRIAGE_RETURN as well, maybe?

I patched via
` public function setTty(string $mode): void
{
$this->initialTtyMode ??= $this->exec('stty -g');

    $this->exec("stty $mode icrnl");
}`

in my repo, I'm not quite sure of all the implications of this approach though.

Steps To Reproduce

stty -icrnl
php artisan make:request
try to press enter
@jessarcher
Copy link
Member

Hey @Carnicero90,

I started working on a PR to accept \r (in addition to \n), which seems to work with -icrnl set. However when I went to stage the commit (using git add -p) I found that -icrnl also broke the Enter key in git, which gave me pause. Instead of staging the hunk, it just output ^M.

I don't think that's a reason not to accept \r, but I'm curious whether git's patch mode UI is also broken for you when pressing Enter?

@jessarcher jessarcher mentioned this issue Nov 20, 2024
Closed
@Carnicero90
Copy link
Author

It does indeed, never noticed since I generally have a dedicate pane for git stuff.
Btw I think the issue may be caused by psysh use of less for pagination, whenever the process doesn't terminate gracefully. I'll try to figure out when that happens, using strace or whatever tracking tool is available in macos.
Thanks.

@jessarcher
Copy link
Member

I'm going to close this and #177 for now. Feel free to reopen if you discover an issue with Prompts.

@Carnicero90
Copy link
Author

Well, I would say on an almost daily basis: not a biggie though, I'm leaving here stty sane as a workaround/solution for whoever would run in the same issue in the future. At least in a unix env, dunno about windows.

@jessarcher
Copy link
Member

Do you know how to replicate it? I've tried running psysh (via tinker) and then running prompts, but the Enter key still works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[0.3.x] Support carriage returns laravel/prompts
2 participants
@jessarcher @Carnicero90