Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for issue #1434 #1435

Merged
merged 3 commits into from
Jun 30, 2024
Merged

Bugfix for issue #1434 #1435

merged 3 commits into from
Jun 30, 2024

Conversation

erezsh
Copy link
Member

@erezsh erezsh commented Jun 30, 2024

Fixes #1434

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.77%. Comparing base (5016894) to head (7547758).

Files Patch % Lines
lark/utils.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
- Coverage   89.78%   89.77%   -0.01%     
==========================================
  Files          52       52              
  Lines        7811     7818       +7     
==========================================
+ Hits         7013     7019       +6     
- Misses        798      799       +1     
Flag Coverage Δ
unittests 89.77% <90.90%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erezsh
Copy link
Member Author

erezsh commented Jun 30, 2024

Not much to review but I'll follow protocol just in case.

@MegaIng
Copy link
Member

MegaIng commented Jun 30, 2024

If this is a bugfix, we should have tests that fail (sometimes) beforehand.

Although, for that we ideally had infrastructure to start a new process with different, controllable hash seeds which then execute the snippet we want to check out.

@erezsh
Copy link
Member Author

erezsh commented Jun 30, 2024

Added. Anything else?

@erezsh erezsh merged commit be542c2 into master Jun 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent parse results from simple ambiguous grammar
3 participants