Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable Length Arrays not supported by MSVC. #48

Open
sizeak opened this issue May 31, 2023 · 1 comment
Open

Variable Length Arrays not supported by MSVC. #48

sizeak opened this issue May 31, 2023 · 1 comment

Comments

@sizeak
Copy link
Contributor

sizeak commented May 31, 2023

Hi, I'm not sure if it's something you want to support, but you can't currently build this with MSVC (Visual Studio). "I don't plan to support MSVC." is a perfectly reasonable response IMO, so no pressure! I don't usually build for Windows, but the Conan CI builds for it by default, so I've been testing with VS 2019.

It seems that they don't support VLAs since they were made optional in C11, and have no plans to ever support them:
https://devblogs.microsoft.com/cppblog/c11-and-c17-standard-support-arriving-in-msvc/#variable-length-arrays

I suppose to support MSVC the VLAs would need replacing with good old malloc. WDYT?

@larsbs
Copy link
Owner

larsbs commented Jun 2, 2023

@simoncent If the only change we have to do is replacing the VLAs, I don't mind. However, currently I don't have the time to doing so (and I don't remember exactly where I could've used them, since I tend to prefer "good ol' malloc".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants