Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new binary frame #51

Open
onderweg opened this issue Aug 26, 2023 · 1 comment
Open

Add new binary frame #51

onderweg opened this issue Aug 26, 2023 · 1 comment

Comments

@onderweg
Copy link

onderweg commented Aug 26, 2023

Hi,

First: thanks for this nice library!

I would like to write a non-standard frame type (ETCO).
This is a binary frame type, so I suppose I cannot use ID3v2_Tag_set_text_frame.

I'm able to create the frame ID3v2_Frame struct manually, but I'm not able to add the frame to the frame list of the tag, because FrameList_add_frame() is private.
Is there any way I can add a frame, that is not text, comment or apic frame, but a binary frame, to the list of frames of a tag?
Or, would it be possible to make FrameList_add_frame non-private?

Thanks!

@larsbs
Copy link
Owner

larsbs commented Aug 30, 2023

@onderweg Hey! I'm not against making FrameList_add_frame non-private if it's required. Feel free to submit a PR with it (and a use case in the description) so I can review it and add it if all is good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants