Use Webocket.send_binary() instead of Websocket.send() #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
websockify dropped support for text frames awhile back [1][2], possibly as of version 0.9.0 [3]. Attempts to send text frames to a sufficiently new websockify server result in the following error returned: Unsupported: Text frames are not supported and then the server closes the connection. This changes the client to call Webocket.send_binary() [4] instead of Websocket.send() in order to send binary data rather than text. websockify has (always?) supported receiving binary data so this should be backward compatible with older versions. Closes larsks#4 [1] novnc/websockify#365 [2] novnc/websockify@8eb5cb0 [3] novnc/websockify@8a69762 [4] https://websocket-client.readthedocs.io/en/latest/core.html#websocket._core.WebSocket.send_binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
websockify dropped support for text frames awhile back [1][2], possibly
as of version 0.9.0 [3]. Attempts to send text frames to a sufficiently
new websockify server result in the following error returned:
Unsupported: Text frames are not supported
and then the server closes the connection.
This changes the client to call Webocket.send_binary() [4] instead of
Websocket.send() in order to send binary data rather than text.
websockify has (always?) supported receiving binary data so this should
be backward compatible with older versions.
Closes #4
[1] novnc/websockify#365
[2] novnc/websockify@8eb5cb0
[3] novnc/websockify@8a69762
[4] https://websocket-client.readthedocs.io/en/latest/core.html#websocket._core.WebSocket.send_binary