-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect CompletableFuture integration #1088
Conversation
The cancellation logic is much more complex than the previous implementation handled This will work correctly with the changes to Async in CE 3.5+
I also tried running |
you are right, i didn't polish codegen. every time i update sdk versions, i do codegen and then manually fix imports and method overload issues. thanks for the contribution, this makes sense. |
merging this guy, thank you for the contrubution @Daenyth |
The cancellation logic is much more complex than the previous implementation handled
This will work correctly with the changes to Async in CE 3.5+