Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect CompletableFuture integration #1088

Merged
merged 12 commits into from
Sep 21, 2023

Conversation

Daenyth
Copy link
Contributor

@Daenyth Daenyth commented Sep 5, 2023

The cancellation logic is much more complex than the previous implementation handled

This will work correctly with the changes to Async in CE 3.5+

The cancellation logic is much more complex than the previous implementation
handled

This will work correctly with the changes to Async in CE 3.5+
@Daenyth
Copy link
Contributor Author

Daenyth commented Sep 5, 2023

I also tried running sbt taglessGen but it looks like current state of the files was manually edited using that as a base - it doesn't compile as-is, there's duplicate methods emitted and a lot of noise in the imports

@semenodm
Copy link
Member

semenodm commented Sep 5, 2023

you are right, i didn't polish codegen. every time i update sdk versions, i do codegen and then manually fix imports and method overload issues.

thanks for the contribution, this makes sense.

@semenodm
Copy link
Member

merging this guy, thank you for the contrubution @Daenyth

@semenodm semenodm merged commit 8c54a36 into laserdisc-io:main Sep 21, 2023
2 checks passed
@Daenyth Daenyth deleted the async-fix branch October 6, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants