-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elastic Beanstalk Support #194
base: main
Are you sure you want to change the base?
Conversation
30c0940
to
3120d16
Compare
3120d16
to
9c2f371
Compare
Not sure what's up, but there's a test from something outside the scope of my changes that's failing on the latest build (weirdly 264.11 alone). Everything was passing the first time I made this PR (Build 263). 😕 |
@fny any luck in making this test pass? |
9c2f371
to
f3009ed
Compare
f3009ed
to
4c2a9a8
Compare
Yes, but I cheated. I just pushed a change to the README, and all is well. It looks like there's a bug elsewhere Figaro that makes that spec randomly fail on Ruby 1.9.3 and Rails 3.2: See #200. |
Would love to see this merged! |
Is this still waiting on merge conflicts to be resolved? |
No. @laserlemon just seems uninterested in this feature. There were no conflicts when this PR was originally made, it's just been sitting around for awhile. |
Any updates on this? |
@laserlemon think this is still mergeable? |
Changes Unknown when pulling 4c2a9a8 on fny:elastic-beanstalk-support into ** on laserlemon:master**. |
@laserlemon Um..why hasnt this been merged already? |
It would be great to see this merged. 👍 |
This commit adds AWS Elastic Beanstalk support through
figaro eb:set
. All of the related option accoutrements are included too.I also extracted the command-related expectations into an
expect_ran
helper to DRY things up a bit.Fixes #193. Passing version of #187.