Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support protobuf keyword completion #10

Merged
merged 2 commits into from
Jan 1, 2024
Merged

support protobuf keyword completion #10

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f68ef7d
Fix attempt to get length of local diagnostics (a nil value)
lonnywong Dec 31, 2023
e0c4eec
support protobuf keyword completion
lonnywong Dec 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion proto/view/view.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,9 @@ func (v *view) sendDiagnose(document_uri defines.DocumentUri, err error) {
},
}
defer func() {
ViewManager.Server.SendMsg(res)
if len(res.Params.Diagnostics) > 0 {
lasorda marked this conversation as resolved.
Show resolved Hide resolved
_ = ViewManager.Server.SendMsg(res)
}
}()
if err == nil {
return
Expand Down