Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Selection handles NaN and NullData #305

Open
dlindhol opened this issue Jun 29, 2021 · 1 comment
Open

Make sure Selection handles NaN and NullData #305

dlindhol opened this issue Jun 29, 2021 · 1 comment

Comments

@dlindhol
Copy link
Member

The value pattern match at line 58 of Selection.scala is not exhaustive. It does not have a case for Some(Data) which is where NullData would fall.

It's also not clear how ordering works for NaNs (in light of TotalOrdering vs IeeeOdering).

I'm thinking that we should use things like Ordering.gt instead of using our matches on the result of a tryCompare. The ordering test should always be false for NaN and NullData.

@dlindhol
Copy link
Member Author

Substitution also has a non-exhaustive match. The return to NullData as a possibility for Scalars instead of NullDatum has made this a bigger issue.

dlindhol added a commit that referenced this issue Jun 29, 2021
Many remaining warnings relate to exhaustivity of DataType (#304)
and Data matches (#305).
dlindhol added a commit that referenced this issue Jun 30, 2021
Many remaining warnings relate to exhaustivity of DataType (#304)
and Data matches (#305).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant