You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The value pattern match at line 58 of Selection.scala is not exhaustive. It does not have a case for Some(Data) which is where NullData would fall.
It's also not clear how ordering works for NaNs (in light of TotalOrdering vs IeeeOdering).
I'm thinking that we should use things like Ordering.gt instead of using our matches on the result of a tryCompare. The ordering test should always be false for NaN and NullData.
The text was updated successfully, but these errors were encountered:
The value pattern match at line 58 of Selection.scala is not exhaustive. It does not have a case for
Some(Data)
which is whereNullData
would fall.It's also not clear how ordering works for NaNs (in light of TotalOrdering vs IeeeOdering).
I'm thinking that we should use things like
Ordering.gt
instead of using ourmatches
on the result of atryCompare
. The ordering test should always be false for NaN and NullData.The text was updated successfully, but these errors were encountered: