You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should setting scale on floating point fields be rejected (i.e. require scale = 1.0), or should it be allowed on all precisions and likewise taken into account in Accessor?
Also, LinkMax is not used in Accessor, but only in Reconstruct. Should that be used in Accessor too?
The text was updated successfully, but these errors were encountered:
The test suite sets
scale
for the staggered gauge field parameters (https://github.com/lattice/quda/blob/develop/tests/utils/set_params.cpp#L100) which then gets set for both the fat and long link gauge fields. These are initially floating point fields, but the code (https://github.com/lattice/quda/blob/develop/include/lattice_field.h#L229) implies it should only be set for fixed point fields, and it likewise seems to be ignored for floating point fields. This leads to an inconsistency when the fields are copied to half precision, since this is still set and nowAccessor
will honor the scale (https://github.com/lattice/quda/blob/develop/include/gauge_field_order.h#L644) whereas it didn't in the floating point version.Should setting
scale
on floating point fields be rejected (i.e. requirescale = 1.0
), or should it be allowed on all precisions and likewise taken into account inAccessor
?Also,
LinkMax
is not used inAccessor
, but only inReconstruct
. Should that be used inAccessor
too?The text was updated successfully, but these errors were encountered: