Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting gauge field scale for floating point types #1508

Open
jcosborn opened this issue Oct 26, 2024 · 0 comments
Open

Setting gauge field scale for floating point types #1508

jcosborn opened this issue Oct 26, 2024 · 0 comments

Comments

@jcosborn
Copy link
Contributor

The test suite sets scale for the staggered gauge field parameters (https://github.com/lattice/quda/blob/develop/tests/utils/set_params.cpp#L100) which then gets set for both the fat and long link gauge fields. These are initially floating point fields, but the code (https://github.com/lattice/quda/blob/develop/include/lattice_field.h#L229) implies it should only be set for fixed point fields, and it likewise seems to be ignored for floating point fields. This leads to an inconsistency when the fields are copied to half precision, since this is still set and now Accessor will honor the scale (https://github.com/lattice/quda/blob/develop/include/gauge_field_order.h#L644) whereas it didn't in the floating point version.

Should setting scale on floating point fields be rejected (i.e. require scale = 1.0), or should it be allowed on all precisions and likewise taken into account in Accessor?

Also, LinkMax is not used in Accessor, but only in Reconstruct. Should that be used in Accessor too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant