Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDClient#*VariationDetail returns null EvaluationReason with r8 enabled #273

Open
tevjef opened this issue Jun 28, 2024 · 4 comments
Open

Comments

@tevjef
Copy link

tevjef commented Jun 28, 2024

Describe the bug
LDClient#*VariationDetail returns null EvaluationReason with r8 enabled

Expected behavior
I expect the EvaluationReason to never be null on both debug and release builds of our app.

Logs

Logging the detail and reason on release builds shows the value is null.

image

SDK version
5.3.0

Language version, developer tools

AGP 8.4.x with r8 full mode is enabled.

@tanderson-ld
Copy link
Contributor

HI @tevjef, thank you for reporting this. I believe this issue that is open is a semi-match and the workaround in it could potentially work for you. We have also filed an issue internally for R8 and will get to it when priorities allow. Please let me know if the workaround in that other issue works for you.

@tevjef
Copy link
Author

tevjef commented Jul 2, 2024

@tanderson-ld Hey, adding those rule does not work for me. I see those rules are already part of the consumer-proguard rules.

@tanderson-ld
Copy link
Contributor

Are you able to experiment with excluding all LaunchDarkly classes?

I have also linked this issue to our internally tracked R8 Ticket, 199469

@sgjesse
Copy link

sgjesse commented Sep 4, 2024

Maybe stating the obvious here, but as this SDK already has consumer keep rules, they might just have a missing some rule. One thing I noticed was that these rules also have Gson rules included. However, with the release of Gson 2.11.0 I think they can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants