-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: Update sdk-client rollup configuration to match common (#630)
This applies the same fixes to `sdk-client` that were applied to `common`. This resolves issues with using CJS+Typescript with RN. Our existing test project doesn't use node16/nodenext module resolution. Can be tested with our example project with this tsconfig. ``` { "extends": "@react-native/typescript-config/tsconfig.json", "compilerOptions": { "allowSyntheticDefaultImports": true, "jsx": "react-native", "lib": ["dom", "esnext"], "module": "nodenext", "moduleResolution": "nodenext", "noEmit": true, "skipLibCheck": true, "resolveJsonModule": true, "removeComments": true, "sourceMap": true, "strict": true, "forceConsistentCasingInFileNames": true }, "exclude": ["e2e"] } ``` Required installing the base config: ``` yarn add -D @react-native/typescript-config ```
- Loading branch information
1 parent
70cf3c3
commit e061811
Showing
3 changed files
with
25 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters