-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: select child resources based on parent key #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to Shortcut Story #235547: Create stubbed out setup command to act as a prototype. |
sunnyguduru
approved these changes
Mar 18, 2024
k3llymariee
commented
Mar 18, 2024
l := list.New(environmentsToItems(environments), envDelegate{}, 30, 14) | ||
func getEnvironments(projKey string) ([]environment, error) { | ||
envList := environments[projKey] | ||
createNewOption := environment{Key: CreateNewResourceKey, Name: "Create a new environment"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now choosing this option won't actually do anything (except for projects)
sunnyguduru
pushed a commit
that referenced
this pull request
Mar 18, 2024
* add new text input mmodel * add new input step to project model, update wizard step to handle that update * add note about error handling; * remove debugging stmt * store projects in memory so we can mimic adding new ones * refetch projects if we go back to that step from environment step * make fetching resources more generic * fetch environments based on project selected * fetch flags based on environment selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes the prototype a little more realistic when we choose child resources based on the parent (e.g. show different envs for different projects)
select-child-resources.mov