feat: Implement environment update functionality in launchdevly ui #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdelst
changed the title
cdelst
commented
Sep 11, 2024
| type Server struct { | ||
| var _ StrictServerInterface = server{} | ||
|
|
||
| type server struct { |
There was a problem hiding this comment.
this should be private
cdelst
commented
Sep 11, 2024
| } | ||
|
|
||
| func NewStrictServer() Server { | ||
| return Server{} | ||
| func NewStrictServer() StrictServerInterface { |
There was a problem hiding this comment.
we want to return the interface not the struct
cdelst
commented
Sep 11, 2024
cdelst
commented
Sep 11, 2024
internal/dev_server/api/server.go
Outdated
| return GetProjectsEnvironments404JSONResponse{}, nil | ||
| } | ||
|
|
||
| environments, err := project.Environments(ctx) |
There was a problem hiding this comment.
I need to refactor this off the project rep still. On my list
cdelst
commented
Sep 11, 2024
| @@ -83,9 +83,9 @@ func (s Sqlite) UpdateProject(ctx context.Context, project model.Project) (bool, | |||
| }() | |||
| result, err := tx.ExecContext(ctx, ` | |||
| UPDATE projects | |||
| SET flag_state = ?, last_sync_time = ?, context=? | |||
| SET flag_state = ?, last_sync_time = ?, context=?, source_environment_key=? | |||
There was a problem hiding this comment.
was this intentionally left out? I saw some tests that might suggest so.
cdelst
commented
Sep 11, 2024
cdelst
commented
Sep 11, 2024
| @@ -77,6 +78,7 @@ func (c LDClient) RunServer(ctx context.Context, serverParams ServerParams) { | |||
|
|
|||
| func getDBPath() string { | |||
| dbFilePath, err := xdg.StateFile("ldcli/dev_server.db") | |||
| log.Printf("Using database at %s", dbFilePath) | |||
There was a problem hiding this comment.
useful for locally connecting to the db
cdelst
commented
Sep 11, 2024
mike-zorn
reviewed
Sep 11, 2024
mike-zorn
reviewed
Sep 12, 2024
mike-zorn
approved these changes
Sep 12, 2024
cdelst
deleted the
cdelst/sc-255156/add-ui-support-for-editing-a-project
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/547246f3f0384ff69260bd744e9dd392