sc-235696/add viper #8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,34 @@ | ||
| package cmd | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/spf13/cobra" | ||
| "github.com/spf13/viper" | ||
| ) | ||
|
|
||
| func newHelloCmd() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "hello", | ||
| Short: "A hello world command.", | ||
| Long: `A hello world command that prints out {"hello": "world"}`, | ||
| RunE: runHello, | ||
| } | ||
|
|
||
| // bind command-specific flags | ||
| cmd.Flags().BoolP("informal", "i", false, "Make the greeting less formal") | ||
| _ = viper.BindPFlag("informal", cmd.Flags().Lookup("informal")) | ||
|
There was a problem hiding this comment. We can keep the command-specific stuff in the constructor so we don't need to do this all in the root command. |
||
|
|
||
| return cmd | ||
| } | ||
|
|
||
| func runHello(cmd *cobra.Command, args []string) error { | ||
| out := `{"hello": "world"}` | ||
| if viper.GetBool("informal") { | ||
| out = `{"hi": "world"}` | ||
| } | ||
|
|
||
| fmt.Fprintf(cmd.OutOrStdout(), out+"\n") | ||
|
|
||
| return nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're going to want this pattern to eventually pass in dependencies. I'd like to move away from a global
vipervariable since it's implicit state, but it's easier to leave it as-is for now.