Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to set 'keep note history for' accurately from the mobile app #10883

Open
mrjo118 opened this issue Aug 16, 2024 · 11 comments · May be fixed by #11822
Open

Not possible to set 'keep note history for' accurately from the mobile app #10883

mrjo118 opened this issue Aug 16, 2024 · 11 comments · May be fixed by #11822
Labels
backlog We'll get to it... eventually... enhancement Feature requests and code enhancements mobile All mobile platforms

Comments

@mrjo118
Copy link
Contributor

mrjo118 commented Aug 16, 2024

Operating system

Android

Joplin version

3.0.8

Desktop version info

Using an Android 10 device

Current behaviour

In the note history configuration screen, the 'keep note history for' option is a slider element. Even with the device rotated to landscape mode, the bar is not very long, so it is impossible to set an accurate value for it (except the min and max) without any external input devices

Expected behaviour

An alternative UI element should be used to allow accurate setting of the value. For example a textbox, as is used in the desktop version

Logs

No response

@mrjo118 mrjo118 added the bug It's a bug label Aug 16, 2024
@Julrob199
Copy link

I have been waiting for this for a long time 🙏

@mrjo118
Copy link
Contributor Author

mrjo118 commented Sep 9, 2024

Having a look at the code, if I'm understanding this correctly, it seems to be wherever an entry in builtInMetadata.ts has a type of SettingItemType.Int set, it will use the ui component where md.type === Setting.TYPE_INT in SettingComponent.tsx. I can see that for the app-mobile SettingComponent.tsx class, it uses a React Native Slider component, while in the app-desktop varient of the class, it just uses a text input with up and down buttons, but also allow entering any number as free text without validation. I would question whether we should use the Slider component at all on mobile, considering that the desktop version does not use them, and it's not just the 'keep note history for' option that it causes a problem for, but also the 'Keep notes in the trash for' option as well.

Could we not replace the slider component with a TextInput with keyboardType='numeric' (as suggested here https://stackoverflow.com/questions/32946793/react-native-textinput-that-only-accepts-numeric-characters) and then add some validation in onChanged to only allow number characters as a belt and braces if someone uses an external input device?

Copy link
Contributor

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Oct 10, 2024
@mrjo118
Copy link
Contributor Author

mrjo118 commented Oct 10, 2024

Still an issue

@github-actions github-actions bot removed the stale An issue that hasn't been active for a while... label Oct 11, 2024
Copy link
Contributor

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Nov 11, 2024
@mrjo118
Copy link
Contributor Author

mrjo118 commented Nov 12, 2024

Still an issue

@github-actions github-actions bot removed the stale An issue that hasn't been active for a while... label Nov 12, 2024
Copy link
Contributor

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Dec 12, 2024
@mrjo118
Copy link
Contributor Author

mrjo118 commented Dec 12, 2024

Still an issue

@github-actions github-actions bot removed the stale An issue that hasn't been active for a while... label Dec 13, 2024
Copy link
Contributor

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@github-actions github-actions bot added the stale An issue that hasn't been active for a while... label Jan 14, 2025
@mrjo118
Copy link
Contributor Author

mrjo118 commented Jan 14, 2025

Still an issue

@github-actions github-actions bot removed the stale An issue that hasn't been active for a while... label Jan 15, 2025
@personalizedrefrigerator personalizedrefrigerator added enhancement Feature requests and code enhancements mobile All mobile platforms backlog We'll get to it... eventually... and removed bug It's a bug labels Jan 15, 2025
@Julrob199
Copy link

Still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We'll get to it... eventually... enhancement Feature requests and code enhancements mobile All mobile platforms
Projects
None yet
3 participants