Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Solana spec #1806

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: update Solana spec #1806

wants to merge 5 commits into from

Conversation

oren-lava
Copy link
Collaborator

@oren-lava oren-lava commented Nov 26, 2024

Description

Closes: #XXXX

Note, the spec is missing subscription APIs. Not added since it requires code modifications (will add them in a future PR)

Solana spec update:

  1. Added API: getMaxShredInsertSlot

  2. Removed deprecated API: confirmTransaction, getConfirmedBlock, getConfirmedBlocks, getConfirmedBlocksWithLimit, getConfirmedSignaturesForAddress2, getConfirmedTransaction, getFeeCalculatorForBlockhash, getFeeRateGovernor, getFees, getRecentBlockhash, getSignatureConfirmation, getSignatureStatus, getSnapshotSlot, getStakeActivation


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Nov 26, 2024

Test Results

2 340 tests  ±0   2 340 ✅ ±0   27m 50s ⏱️ +11s
  145 suites ±0       0 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit fc4e8cb. ± Comparison against base commit 04db676.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants