Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When activating next/prev gutter annotation, take into account hidden annotations #83

Open
longhotsummer opened this issue Mar 3, 2022 · 0 comments · May be fixed by #85
Open

When activating next/prev gutter annotation, take into account hidden annotations #83

longhotsummer opened this issue Mar 3, 2022 · 0 comments · May be fixed by #85
Assignees

Comments

@longhotsummer
Copy link
Contributor

We have this logic in Indigo, but there's no reason it couldn't live here. laws-africa/indigo#1425

If the caller provides the threshold (ie. the container's scrollTop), then this library can do the necessary to find the appropriate annotation and activate it. That would mean callers don't have to straddle sometimes calling this lib, and sometimes doing it themselves.

@musangowope musangowope self-assigned this Mar 7, 2022
@musangowope musangowope linked a pull request Mar 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants