Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iterate through docs only if available #2165

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Sandravaphilips
Copy link
Collaborator

Closes #2151

Copy link

Test Results

3 tests  +1   3 ✅ +1   0s ⏱️ ±0s
2 suites +1   0 💤 ±0 
2 files   +1   0 ❌ ±0 

Results for commit 40a35ac. ± Comparison against base commit da9913e.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.
africanlii.tests.test_views.AfricanliiViewsTest ‑ test_homepage
africanlii.tests.test_views.AfricanliiViewsTest ‑ test_legal_instrument_listing
liiweb.tests.test_legislation_views.LegislationViewsTest ‑ test_legislation_listing_national_only
liiweb.tests.test_mnc_matcher.MncMatcherTest ‑ test_html_matches
liiweb.tests.test_mnc_matcher.MncMatcherTest ‑ test_za_provincial_matches

Copy link

github-actions bot commented Nov 16, 2024

Test Results

3 tests  +1   3 ✅ +1   0s ⏱️ ±0s
2 suites +1   0 💤 ±0 
2 files   +1   0 ❌ ±0 

Results for commit 40a35ac. ± Comparison against base commit f7d5f13.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.
africanlii.tests.test_views.AfricanliiViewsTest ‑ test_homepage
africanlii.tests.test_views.AfricanliiViewsTest ‑ test_legal_instrument_listing
liiweb.tests.test_legislation_views.LegislationViewsTest ‑ test_legislation_listing_national_only
liiweb.tests.test_mnc_matcher.MncMatcherTest ‑ test_html_matches
liiweb.tests.test_mnc_matcher.MncMatcherTest ‑ test_za_provincial_matches

♻️ This comment has been updated with latest results.

@actlikewill
Copy link
Contributor

for this one, it would be better to get a list of all ids and then use them in the for loop rather than use the iterator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoreDocument.DoesNotExist: CoreDocument matching query does not exist.
2 participants