From f709b5bbef679b3b0c933468a133669de2c75f13 Mon Sep 17 00:00:00 2001 From: Sudhanshu Dasgupta Date: Fri, 8 Nov 2024 12:30:55 +0530 Subject: [PATCH 1/2] feat(catalog): enhance Signed-off-by: Sudhanshu Dasgupta --- src/custom/CatalogDetail/LeftPanel.tsx | 2 +- src/custom/CatalogDetail/RelatedDesigns.tsx | 9 +++++++-- src/custom/CatalogDetail/RightPanel.tsx | 8 +++++++- src/custom/CatalogDetail/UserInfo.tsx | 17 ++++++++++++++++- src/custom/CatalogDetail/style.tsx | 5 +++-- 5 files changed, 34 insertions(+), 7 deletions(-) diff --git a/src/custom/CatalogDetail/LeftPanel.tsx b/src/custom/CatalogDetail/LeftPanel.tsx index 70ed50d2..0fe0b63d 100644 --- a/src/custom/CatalogDetail/LeftPanel.tsx +++ b/src/custom/CatalogDetail/LeftPanel.tsx @@ -70,7 +70,7 @@ const LeftPanel: React.FC = ({ imgURL={details?.catalog_data?.imageURL} height={'100%'} width={'100%'} - zoomEffect={false} + zoomEffect={true} type={{ type: type }} /> diff --git a/src/custom/CatalogDetail/RelatedDesigns.tsx b/src/custom/CatalogDetail/RelatedDesigns.tsx index d1ed6726..9449f21f 100644 --- a/src/custom/CatalogDetail/RelatedDesigns.tsx +++ b/src/custom/CatalogDetail/RelatedDesigns.tsx @@ -16,6 +16,8 @@ interface RelatedDesignsProps { userProfile?: UserProfile; technologySVGPath: string; technologySVGSubpath: string; + orgName: string; + fetchingOrgError: boolean; } const RelatedDesigns: React.FC = ({ @@ -25,7 +27,9 @@ const RelatedDesigns: React.FC = ({ onSuggestedPatternClick, userProfile, technologySVGPath, - technologySVGSubpath + technologySVGSubpath, + orgName, + fetchingOrgError }) => { const filteredPatternsPerUser = patternsPerUser?.patterns?.filter( (pattern) => pattern.id !== details.id @@ -37,7 +41,8 @@ const RelatedDesigns: React.FC = ({

- Other published design by {formatToTitleCase(userProfile?.first_name ?? '')} + Other published design by {formatToTitleCase(userProfile?.first_name ?? '')}{' '} + {fetchingOrgError ? '' : `under ${orgName}`}

diff --git a/src/custom/CatalogDetail/RightPanel.tsx b/src/custom/CatalogDetail/RightPanel.tsx index 5fc88f1f..24d52f07 100644 --- a/src/custom/CatalogDetail/RightPanel.tsx +++ b/src/custom/CatalogDetail/RightPanel.tsx @@ -24,6 +24,8 @@ interface RightPanelProps { fontFamily?: string; technologySVGPath: string; technologySVGSubpath: string; + orgName: string; + fetchingOrgError: boolean; } const RightPanel: React.FC = ({ @@ -43,7 +45,9 @@ const RightPanel: React.FC = ({ fontFamily, useGetUserProfileByIdQuery, technologySVGPath, - technologySVGSubpath + technologySVGSubpath, + orgName, + fetchingOrgError }) => { const cleanedType = type.replace('my-', '').replace(/s$/, ''); const { data: userProfile } = useGetUserProfileByIdQuery({ @@ -69,6 +73,8 @@ const RightPanel: React.FC = ({ {showCaveats && } = ({ details, showVersion = true, userPr <> CREATED BY - + + (({ disabled = fa flex: '1' })); -export const ContentDetailsText = styled(Typography)(({ theme }) => ({ +export const ContentDetailsText = styled(Typography)(({ theme, style }) => ({ fontFamily: 'inherit', fontSize: '1rem', color: theme.palette.text.default, ['@media (min-width:1200px)']: { fontSize: '1' - } + }, + ...style })); export const ContentHeading = styled('div')(() => ({ From 73f74dd100651ea0dd02689bc8b525b96121fae9 Mon Sep 17 00:00:00 2001 From: jerensl <54782057+jerensl@users.noreply.github.com> Date: Sat, 9 Nov 2024 12:51:31 +0800 Subject: [PATCH 2/2] ci: fix release bump Signed-off-by: jerensl <54782057+jerensl@users.noreply.github.com> --- .github/workflows/bump-meshery-version.yml | 2 +- .github/workflows/release.yml | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/bump-meshery-version.yml b/.github/workflows/bump-meshery-version.yml index bfd24c16..00dde73e 100644 --- a/.github/workflows/bump-meshery-version.yml +++ b/.github/workflows/bump-meshery-version.yml @@ -15,7 +15,7 @@ jobs: - name: Download Version uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8 with: - name: e2e-test-reporter + name: version-number github-token: ${{ secrets.GH_ACCESS_TOKEN }} run-id: ${{ github.event.workflow_run.id }} - name: Retrieve Version diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 31260f5c..71339d20 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -47,22 +47,20 @@ jobs: versions-check: needs: publish-gpr runs-on: ubuntu-latest - outputs: - current: ${{ steps.versions.outputs }} steps: - uses: actions/github-script@v7 id: versions with: result-encoding: string script: | - let str = "${{github.event.release.tag_name}}" + let str = `${{github.event.release.tag_name}}` return str.replace(/^v/, '') - name: Save Release number if: ${{ !cancelled() }} run: | mkdir -p ./version - echo ${{ steps.versions.outputs }} > ./version/number + echo ${{ steps.versions.outputs.result }} > ./version/number - name: Upload Version Report if: ${{ !cancelled() }} uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6