Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Lookup Release Version # When Manually Releasing #100

Open
leecalcote opened this issue Sep 27, 2023 · 3 comments
Open

[CI] Lookup Release Version # When Manually Releasing #100

leecalcote opened this issue Sep 27, 2023 · 3 comments

Comments

@leecalcote
Copy link
Member

          While dispatching, if one of the steps here isn't dynamically identifying the latest release tag, we might want to require the release tag as input here. 

You might like to grab the release tag lookup "function" from another one of the makefiles / workflows.

Originally posted by @leecalcote in #95 (comment)

@nebula-aac
Copy link
Contributor

Updated GitHub Actions workflow to release from using lerna

But I'm running into an issue with GitHub Actions to publish a release:

https://github.com/layer5io/sistent/actions/runs/6343737428/job/17232399284

@leecalcote
Copy link
Member Author

Any reason not to use the pre-established and pre-debugged approach that we’re already using?

@nebula-aac
Copy link
Contributor

Any reason not to use the pre-established and pre-debugged approach that we’re already using?

The workflow is still attempting to publish via GitHub Release, but before, whenever you use yarn to build and release, you can only run yarn in the current directory, not throughout the workspace.

It is better to allow a build tool to help automate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants