Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[components]: Create custom YAMLDialog #312

Open
3 tasks
Tracked by #402
nebula-aac opened this issue Nov 11, 2023 · 1 comment
Open
3 tasks
Tracked by #402

[components]: Create custom YAMLDialog #312

nebula-aac opened this issue Nov 11, 2023 · 1 comment
Assignees
@nebula-aac
Labels
component/components kind/enhancement Improvement in current feature v0.17.0-planning

Comments

@nebula-aac
Copy link
Contributor

Current Behavior

Meshery UI has a YAMLDialog component that would benefit from being reused.

Desired Behavior

  • Create reusable component
  • Set the generic props used across multiple pages that uses this
  • Ensure that DialogContent has props and wraps children as this is where the Codemirror is being used

Implementation

Acceptance Tests

Mockups

Contributor Guide
@nebula-aac nebula-aac added the kind/enhancement Improvement in current feature label Nov 11, 2023
@nebula-aac
Copy link
Contributor Author

Update: I have this partially done testing in the Next.js PR, but have not implemented in the components package.

@nebula-aac nebula-aac self-assigned this Nov 15, 2023
@nebula-aac nebula-aac mentioned this issue Dec 5, 2023
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nebula-aac nebula-aac

Labels
component/components kind/enhancement Improvement in current feature v0.17.0-planning
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nebula-aac