Updated timetable scraping to reflect new Lang Req column #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dartmouth added a new column to the timetable to indicate something about the new language requirement for incoming students, so we have to adjust a couple lines to reflect the change in the number of columns being scraped from the timetable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Dartmouth added a new column to the timetable to indicate something about the new language requirement for incoming students, so we have to adjust a couple lines to reflect the change in the number of columns being scraped from the timetable
Implementation
Adding the language requirement key to the request body, changing the assertion about the expected number of columns, and changing some list indices of the parsed timetable. All these are in
timetable.py.