From 0a1994974bc9d1af62bb1f45797e6bba424138ee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lazar=20Ljubenovi=C4=87?= <lazar.ljubenovic.1995@gmail.com>
Date: Fri, 3 Nov 2023 14:59:10 +0100
Subject: [PATCH] feat(operators/chunk): improve types

When the `chunkSize` value is known at compile-time, the return type of the operator will now reflect that and return a suitable union of tuples instead of an array with a generic length.

For example, `chunk(3)` will now return `Operator<T, [T] | [T, T] | [T, T, T]>` instead of `Operator<T, Array<T>>`.

Closes #13
---
 src/operators/chunk.ts  | 13 ++++++++++++-
 tests/operators.spec.ts | 10 ++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/src/operators/chunk.ts b/src/operators/chunk.ts
index 2cbacc0..a27486a 100644
--- a/src/operators/chunk.ts
+++ b/src/operators/chunk.ts
@@ -40,13 +40,24 @@ import { Operator } from '../core/types'
  * )
  * // => [[1, 2], [3, 4], [5]]
  */
+export function chunk<T> (chunkSize: 1): Operator<T, [T]>
+export function chunk<T> (chunkSize: 2): Operator<T, [T] | [T, T]>
+export function chunk<T> (chunkSize: 3): Operator<T, [T] | [T, T] | [T, T, T]>
+export function chunk<T> (chunkSize: 4): Operator<T, [T] | [T, T] | [T, T, T] | [T, T, T, T]>
+export function chunk<T> (chunkSize: 5): Operator<T, [T] | [T, T] | [T, T, T] | [T, T, T, T] | [T, T, T, T, T]>
+export function chunk<T> (chunkSize: 6): Operator<T, [T] | [T, T] | [T, T, T] | [T, T, T, T] | [T, T, T, T, T] | [T, T, T, T, T, T]>
+export function chunk<T> (chunkSize: 7): Operator<T, [T] | [T, T] | [T, T, T] | [T, T, T, T] | [T, T, T, T, T] | [T, T, T, T, T, T] | [T, T, T, T, T, T, T]>
+export function chunk<T> (chunkSize: 8): Operator<T, [T] | [T, T] | [T, T, T] | [T, T, T, T] | [T, T, T, T, T] | [T, T, T, T, T, T] | [T, T, T, T, T, T, T] | [T, T, T, T, T, T, T, T]>
+export function chunk<T> (chunkSize: 9): Operator<T, [T] | [T, T] | [T, T, T] | [T, T, T, T] | [T, T, T, T, T] | [T, T, T, T, T, T] | [T, T, T, T, T, T, T] | [T, T, T, T, T, T, T, T] | [T, T, T, T, T, T, T, T, T]>
+export function chunk<T> (chunkSize: 10): Operator<T, [T] | [T, T] | [T, T, T] | [T, T, T, T] | [T, T, T, T, T] | [T, T, T, T, T, T] | [T, T, T, T, T, T, T] | [T, T, T, T, T, T, T, T] | [T, T, T, T, T, T, T, T, T] | [T, T, T, T, T, T, T, T, T, T]>
+export function chunk<T> (chunkSize: number): Operator<T, Array<T>>
 export function chunk<T> (chunkSize: number): Operator<T, Array<T>> {
 
   if (!Number.isInteger(chunkSize) || chunkSize < 1) {
     throw new RangeError(`Chunk size must be an integer not less than 1; an attempt was made to define the chunk size as ${chunkSize}.`)
   }
 
-  return function *(iterable: Iterable<T>): IterableIterator<Array<T>> {
+  return function* (iterable: Iterable<T>): IterableIterator<Array<T>> {
     const buffer: Array<T> = []
     let count: number = 0
     for (const item of iterable) {
diff --git a/tests/operators.spec.ts b/tests/operators.spec.ts
index 7589140..d90b0dd 100644
--- a/tests/operators.spec.ts
+++ b/tests/operators.spec.ts
@@ -101,6 +101,16 @@ describe(`Operators`, () => {
       chai.assert.throws(() => j.chunk(-1), RangeError)
     })
 
+    it(`infers the correct type for chunk size 1`, () => {
+      const result = j.pipe([1, 2, 3], j.chunk(1))
+      type Test = AssertTrue<IsExact<typeof result, IterableIterator<[number]>>>
+    })
+
+    it(`infers the correct type for chunk size 2`, () => {
+      const result = j.pipe([1, 2, 3], j.chunk(2))
+      type Test = AssertTrue<IsExact<typeof result, IterableIterator<[number] | [number, number]>>>
+    })
+
     it(`@example 1`, () => {
       const actual = j.pipe(
         [1, 2, 3, 4],