Actually deprecate method deprecated only in comment (#1995)

lballabio · Jun 23, 2024 · ce85bb5 · ce85bb5
2 parents b8ad67a + 63d2e45
commit ce85bb5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/ql/cashflows/cashflows.hpp b/ql/cashflows/cashflows.hpp
@@ -425,7 +425,10 @@ namespace QuantLib {
                               Real accuracy = 1.0e-10,
                               Size maxIterations = 100,
                               Rate guess = 0.0);
-        //! deprecated implied Z-spread.
+        /*! \deprecated Use the other overload.
+                        Deprecated in version 1.35.
+        */
+        [[deprecated("Use the other overload")]]
         static Spread zSpread(const Leg& leg,
                               const ext::shared_ptr<YieldTermStructure>& d,
                               Real npv,

diff --git a/ql/pricingengines/bond/bondfunctions.cpp b/ql/pricingengines/bond/bondfunctions.cpp
@@ -578,8 +578,8 @@ namespace QuantLib {
         dirtyPrice /= 100.0 / bond.notional(settlement);
 
         return CashFlows::zSpread(bond.cashflows(),
-                                  d,
                                   dirtyPrice,
+                                  d,
                                   dayCounter, compounding, frequency,
                                   false, settlement, settlement,
                                   accuracy, maxIterations, guess);