Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FittedBondDiscountCurve: No constraint can be set #982

Closed
CayOest opened this issue Jan 14, 2021 · 4 comments
Closed

FittedBondDiscountCurve: No constraint can be set #982

CayOest opened this issue Jan 14, 2021 · 4 comments
Labels

Comments

@CayOest
Copy link
Contributor

CayOest commented Jan 14, 2021

Hello,

the FittedBondDiscountCurve function calculate() admits that it does not care about constraints:
Constraint constraint = NoConstraint(); in L188.
This constraint = NoConstraint policy is manifested in L219:
Problem problem(costFunction, constraint, x);

However, there is merit in adding constraints to this problem.

I would like to add constraints to the Curve without being forced to do some kind of (pseudo) decorator on FittingBondDiscountCurve::FittingMethod.

This can be easily achieved by adding a Constraint member to FittingBondDiscountCurve::FittingMethod, and making sure that it is of type NoConstraint by default, and it to be settable.

@lballabio
Copy link
Owner

Sure, go ahead. Thanks!

@CayOest
Copy link
Contributor Author

CayOest commented Jan 14, 2021

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

This issue was automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment, or this will be closed in two weeks.

@github-actions github-actions bot added the stale label Oct 2, 2023
@github-actions
Copy link
Contributor

This issue was automatically closed because it has been stalled for two weeks with no further activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants