From 4280986bc3044eb8a92ecbf005b06c672275c3d0 Mon Sep 17 00:00:00 2001 From: "E. Lynette Rayle" Date: Tue, 28 Oct 2014 14:45:43 -0400 Subject: [PATCH] Remove FIXME comment that no longer applies Changed code to use sub-class of Person instead of Person to avoid the problem where Person was already created with a different base_uri. --- spec/ld4l/foaf_rdf/configuration_spec.rb | 3 +-- spec/ld4l/foaf_rdf_spec.rb | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/spec/ld4l/foaf_rdf/configuration_spec.rb b/spec/ld4l/foaf_rdf/configuration_spec.rb index edff4ca..20b049d 100644 --- a/spec/ld4l/foaf_rdf/configuration_spec.rb +++ b/spec/ld4l/foaf_rdf/configuration_spec.rb @@ -56,7 +56,6 @@ class DummyPerson < LD4L::FoafRDF::Person end end - it "should return value of configured base_uri" do LD4L::FoafRDF.configure do |config| config.base_uri = "http://localhost/test_config/" @@ -84,6 +83,7 @@ class DummyPerson < LD4L::FoafRDF::Person end end + describe "LD4L::FoafRDF::Configuration" do describe "#base_uri" do it "should default to localhost" do @@ -105,5 +105,4 @@ class DummyPerson < LD4L::FoafRDF::Person end end end - end diff --git a/spec/ld4l/foaf_rdf_spec.rb b/spec/ld4l/foaf_rdf_spec.rb index 8416918..e2c79a0 100644 --- a/spec/ld4l/foaf_rdf_spec.rb +++ b/spec/ld4l/foaf_rdf_spec.rb @@ -22,7 +22,6 @@ class DummyPerson < LD4L::FoafRDF::Person end it "should use configured value in Person sub-class" do - # FIXME fails if run with all tests because LD4L::FoafRDF::Person is already loaded by other tests with a different base_uri p = DummyPerson.new('1') expect(p.rdf_subject.to_s).to eq "http://localhost/test/1" end