Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login Endpoint #169

Merged
merged 17 commits into from
Aug 13, 2023
Merged

Login Endpoint #169

merged 17 commits into from
Aug 13, 2023

Conversation

zysim
Copy link
Collaborator

@zysim zysim commented Jul 24, 2023

Solves: #149

@zysim zysim self-assigned this Jul 24, 2023
@zysim zysim requested a review from a team as a code owner July 24, 2023 17:57
@zysim zysim marked this pull request as draft July 24, 2023 17:58
@zysim zysim marked this pull request as ready for review July 26, 2023 14:01
TheTedder
TheTedder reviewed Aug 1, 2023
View reviewed changes
@zysim zysim mentioned this pull request Aug 3, 2023
Merged
Dalet
Dalet requested changes Aug 7, 2023
View reviewed changes
@zysim
Copy link
Collaborator Author

zysim commented Aug 8, 2023

Actually; should we even bother with 422 in the first place? We could just do 400 for any malformed, empty, or otherwise invalid inputs.

@zysim zysim requested review from TheTedder and Dalet August 8, 2023 12:02
@TheTedder
Copy link
Contributor

Actually; should we even bother with 422 in the first place? We could just do 400 for any malformed, empty, or otherwise invalid inputs.

I think we're reserving 400 for invalid syntax; i.e., valid JSON never returns 400.

TheTedder
TheTedder requested changes Aug 8, 2023
View reviewed changes
TheTedder
TheTedder reviewed Aug 9, 2023
View reviewed changes
@zysim zysim requested a review from TheTedder August 11, 2023 08:45
@Dalet Dalet mentioned this pull request Aug 11, 2023
Merged
TheTedder
TheTedder reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@TheTedder TheTedder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall. Just one or two things to tweak. Since @Dalet didn't agree about not using consts, I don't mind if you want to revert them.

@zysim zysim requested a review from TheTedder August 12, 2023 15:20
@zysim zysim merged commit c5b7b57 into leaderboardsgg:main Aug 13, 2023
@zysim zysim deleted the LoginEndpoint branch August 13, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dalet Dalet Dalet approved these changes

@TheTedder TheTedder TheTedder approved these changes

Assignees

@zysim zysim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zysim @TheTedder @Dalet