-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swashbuckle annotations #203
Conversation
I honestly don't know if I prefer the look of this change. I feel bad that you've already put in the work on this, but things feel less readable, personally. On top of that, the attributes can't be folded away, which gets distracting. |
32d62eb
to
4c2eb64
Compare
I updated it just in case you change your mind. I think the openapi doc is actually more correct this way. |
Honestly; this is fine. |
a0b7260
to
36f5a02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough for me. I like that we don't need to needlessly-annotate injected services anymore, as well. I wish we could make the error response schema more accurate (e.g. they all show status: 0
instead of the correct error code), but it's whatever. You can always just test out the API itself in the Swagger doc, anyway.
Closes #168