Merge pull request #62 from leanix/feature/CID-3367/validate-push-eve…

…nt-is-enabled-for-GitHub-App CID-3367: Validate push and installation event are enabled for GitHub App
leanix · Dec 19, 2024 · c25c978 · c25c978
2 parents e6eef63 + 0bf67b8
commit c25c978
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/kotlin/net/leanix/githubagent/services/GitHubEnterpriseService.kt b/src/main/kotlin/net/leanix/githubagent/services/GitHubEnterpriseService.kt
@@ -12,7 +12,7 @@ class GitHubEnterpriseService(private val githubClient: GitHubClient) {
 
     companion object {
         val expectedPermissions = listOf("administration", "contents", "metadata")
-        val expectedEvents = listOf("label", "public", "repository")
+        val expectedEvents = listOf("label", "public", "repository", "push", "installation")
     }
     private val logger = LoggerFactory.getLogger(GitHubEnterpriseService::class.java)
 

diff --git a/src/test/kotlin/net/leanix/githubagent/services/GitHubEnterpriseServiceTest.kt b/src/test/kotlin/net/leanix/githubagent/services/GitHubEnterpriseServiceTest.kt
@@ -21,7 +21,7 @@ class GitHubEnterpriseServiceTest {
         val githubApp = GitHubAppResponse(
             slug = "validApp",
             permissions = mapOf("administration" to "read", "contents" to "read", "metadata" to "read"),
-            events = listOf("label", "public", "repository")
+            events = listOf("label", "public", "repository", "push", "installation")
         )
         every { githubClient.getApp(any()) } returns githubApp
 
@@ -41,7 +41,7 @@ class GitHubEnterpriseServiceTest {
         val response = GitHubAppResponse(
             slug = "validApp",
             permissions = mapOf("administration" to "read", "contents" to "read", "metadata" to "read"),
-            events = listOf("label", "public", "repository")
+            events = listOf("label", "public", "repository", "push", "installation")
         )
 
         assertDoesNotThrow { service.validateGithubAppResponse(response) }