Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect output from linter.unnecessarySimpa #180

Open
kbuzzard opened this issue Jul 7, 2023 · 0 comments
Open

incorrect output from linter.unnecessarySimpa #180

kbuzzard opened this issue Jul 7, 2023 · 0 comments

Comments

@kbuzzard
Copy link
Member

kbuzzard commented Jul 7, 2023

import Std.Tactic.Simpa

theorem foo : ℕ = ℤ ↔ False := sorry

example (bar : ℕ = ℤ) : False := by
  simpa [foo] using bar
/-
try 'simp at bar' instead of 'simpa using bar' [linter.unnecessarySimpa]
-/

The linter is correct in that simpa can be avoided, but its suggestion is not correct; it should be suggesting simp [foo] at bar (which works). simp at bar does not close the goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant