Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: splitting up metric spaces files #15790

Closed
wants to merge 12 commits into from

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Aug 14, 2024

No description provided.

Copy link

PR summary 2ec5e228ee

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Topology.Instances.Discrete 881 726 -155 (-17.59%)
Mathlib.Topology.MetricSpace.MetricSeparated 862 827 -35 (-4.06%)
Mathlib.Topology.MetricSpace.Pseudo.Defs 862 828 -34 (-3.94%)
Mathlib.Topology.MetricSpace.Pseudo.Lemmas 875 867 -8 (-0.91%)
Mathlib.Topology.MetricSpace.Pseudo.Constructions 864 858 -6 (-0.69%)
Mathlib.Topology.MetricSpace.Equicontinuity 881 875 -6 (-0.68%)
Mathlib.Analysis.Convex.Extrema 1058 1056 -2 (-0.19%)
Mathlib.Topology.MetricSpace.Cauchy 876 875 -1 (-0.11%)
Mathlib.Topology.Instances.Int 895 894 -1 (-0.11%)
Import changes for all files
Files Import difference
There are 1048 files with changed transitive imports: this is too many to display!

Declarations diff

+ dist_le_of_mem_Icc
+ dist_le_of_mem_Icc_01
+ dist_le_of_mem_uIcc
+ dist_left_le_of_mem_uIcc
+ dist_right_le_of_mem_uIcc
+ instance (priority := 100) DiscreteTopology.metrizableSpace
+ instance [MetricSpace X] : MetricSpace (Additive X) := ‹MetricSpace X›
+ instance [MetricSpace X] : MetricSpace (Multiplicative X) := ‹MetricSpace X›
+ instance [MetricSpace X] : MetricSpace Xᵒᵈ := ‹MetricSpace X›
- Real.dist_le_of_mem_Icc
- Real.dist_le_of_mem_Icc_01
- Real.dist_le_of_mem_uIcc
- Real.dist_left_le_of_mem_uIcc
- Real.dist_right_le_of_mem_uIcc
- instance (priority := 100) DiscreteTopology.metrizableSpace [DiscreteTopology α] :
- instance : PseudoMetricSpace (Additive X) := ‹PseudoMetricSpace X›
- instance : PseudoMetricSpace (Multiplicative X) := ‹PseudoMetricSpace X›

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@joneugster joneugster added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Aug 14, 2024
@grunweg grunweg added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Aug 14, 2024
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde.

@urkud
Copy link
Member

urkud commented Aug 15, 2024

Thanks! 🎉
bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 15, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 15, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 15, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Aug 16, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 16, 2024

This PR was included in a batch that was canceled, it will be automatically retried

mathlib-bors bot pushed a commit that referenced this pull request Aug 16, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: splitting up metric spaces files [Merged by Bors] - chore: splitting up metric spaces files Aug 16, 2024
@mathlib-bors mathlib-bors bot closed this Aug 16, 2024
@mathlib-bors mathlib-bors bot deleted the emetric_diam branch August 16, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants