Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter.style.multiGoal ignores suffices ... by branch #20081

Open
dwrensha opened this issue Dec 19, 2024 · 2 comments
Open

linter.style.multiGoal ignores suffices ... by branch #20081

dwrensha opened this issue Dec 19, 2024 · 2 comments

Comments

@dwrensha
Copy link
Member

import Mathlib.Tactic.Linter.Multigoal

set_option linter.style.multiGoal true

example : 0 = 00 = 0 := by
  refine ⟨?_, ?_⟩
  rfl -- The linter flags this line, as expected.
  rfl


example : 0 = 00 = 00 = 0 := by
  suffices h : 0 = 0 by
    refine ⟨h, ?_, ?_⟩
    rfl -- I expect to see the linter flag this line, but it does not.
    rfl
  rfl

It looks to me like the problem is that the suffices expands in to a focus node, which then get causes everything below that to get ignored:

``Lean.Parser.Tactic.focus,

@dwrensha
Copy link
Member Author

cc @adomani

@dwrensha
Copy link
Member Author

Here is a line in mathlib that should get flagged by the multiGoal linter, but currently does not, due to this bug:

simp only [ne_eq, differentiableAt_const]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant