Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tactic/GCongr): add norm_num as a side goal discharger for gcongr #20234

Closed
wants to merge 7 commits into from
Closed

feat(Tactic/GCongr): add norm_num as a side goal discharger for gcongr #20234

wants to merge 7 commits into from

Conversation

Command-Master
Copy link
Collaborator

Open in Gitpod

@Command-Master Command-Master added WIP Work in progress t-meta Tactics, attributes or user commands labels Dec 25, 2024
@Command-Master Command-Master linked an issue Dec 25, 2024 that may be closed by this pull request
possible bug revealed by failure to apply simple rel, warning/error is confusing #20232
Open
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

PR summary f79594e940

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Command-Master
Copy link
Collaborator Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit f79594e.
There were significant changes against commit c93dd21:

  Benchmark                                                 Metric         Change
  ===============================================================================
- ~Mathlib.Analysis.Analytic.Basic                          instructions     5.6%
- ~Mathlib.Analysis.CStarAlgebra.Unitization                instructions    87.5%
- ~Mathlib.Analysis.Fourier.FourierTransformDeriv           instructions    12.5%
- ~Mathlib.Analysis.SpecialFunctions.Bernstein              instructions   117.1%
- ~Mathlib.Analysis.SpecialFunctions.Trigonometric.Series   instructions    53.8%
- ~Mathlib.Analysis.SpecificLimits.FloorPow                 instructions    25.1%
- ~Mathlib.Combinatorics.SimpleGraph.Regularity.Chunk       instructions    13.4%
- ~Mathlib.Combinatorics.SimpleGraph.Triangle.Removal       instructions    27.5%
- ~Mathlib.Computability.AkraBazzi.AkraBazzi                instructions     8.6%
- ~Mathlib.Data.Complex.Exponential                         instructions    10.7%
- ~Mathlib.NumberTheory.NumberField.Discriminant.Basic      instructions    19.7%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
t-meta Tactics, attributes or user commands WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

possible bug revealed by failure to apply simple rel, warning/error is confusing
2 participants
@Command-Master @leanprover-bot