-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix token id for NFTs #263
Fix token id for NFTs #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you have some NFT of specified color, AmountInput
component will render a select tag, with several options and blank placeholder:
Please, refer Ant Design Documentation for Select and AmountInput around line 88 to address this issue 🤓
I can't reproduce this. Please me know which of the NFTs that does this |
All of them :) |
Is this issue reproducible from the /wallet page? |
This is exactly the place, where I got that screenshot from. |
VOC is not NFT token. |
Technically VOC is also NFT (every ERC1948 is NFT afair). However, I think AmountInput renders to select box only for enumerable NFTs. So it could be both select or text input for NFTs/NSTs |
@MaxStalker its displayed as NFT. |
I am a bit confised about what we are discussing 🤪 |
|
@MaxStalker you are right, ERC20 😅 |
Judging by that screenshot - you've picked VOC, which is ERC20 contract (which you can ensure if you go to registerToken and search for VOC - color 4, ERC20 token.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Antd version we use doesn't support placeholder
for Select
component.
Merged with minor addition here 1e01736
Fixes #229