Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token id for NFTs #263

Closed

Conversation

iamonuwa
Copy link
Member

@iamonuwa iamonuwa commented Dec 15, 2019

Fixes #229

@troggy
Copy link
Member

troggy commented Dec 15, 2019

@iamonuwa maybe fixes #229 ? :)

Copy link
Member

@MaxStalker MaxStalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have some NFT of specified color, AmountInput component will render a select tag, with several options and blank placeholder:
image

Please, refer Ant Design Documentation for Select and AmountInput around line 88 to address this issue 🤓

@iamonuwa
Copy link
Member Author

if you have some NFT of specified color, AmountInput component will render a select tag, with several options and blank placeholder:
image

Please, refer Ant Design Documentation for Select and AmountInput around line 88 to address this issue

I can't reproduce this. Please me know which of the NFTs that does this

@MaxStalker
Copy link
Member

All of them :)
You just need to have at least 1 token of selected color.

@iamonuwa
Copy link
Member Author

All of them :)
You just need to have at least 1 token of selected color.

Is this issue reproducible from the /wallet page?

@MaxStalker
Copy link
Member

This is exactly the place, where I got that screenshot from.

@iamonuwa
Copy link
Member Author

This is exactly the place, where I got that screenshot from.

This is what I see
image

@MaxStalker
Copy link
Member

VOC is not NFT token.
Try anything below SDST token in that dropdown

@troggy
Copy link
Member

troggy commented Dec 16, 2019

Technically VOC is also NFT (every ERC1948 is NFT afair). However, I think AmountInput renders to select box only for enumerable NFTs.

So it could be both select or text input for NFTs/NSTs

@MaxStalker
Copy link
Member

Technically VOC is also NFT (every ERC1948 is NFT afair)

Pretty sure VOC is ERC20 👇
image

@iamonuwa
Copy link
Member Author

@MaxStalker its displayed as NFT.

@MaxStalker
Copy link
Member

I am a bit confised about what we are discussing 🤪
@iamonuwa can you put a screenshot of the whole page how it renders for you with proposed changes?

@iamonuwa
Copy link
Member Author

I am a bit confised about what we are discussing 🤪
@iamonuwa can you put a screenshot of the whole page how it renders for you with proposed changes?

Screenshot from 2019-12-16 19-47-07

@troggy
Copy link
Member

troggy commented Dec 16, 2019

@MaxStalker you are right, ERC20 😅

@MaxStalker
Copy link
Member

Judging by that screenshot - you've picked VOC, which is ERC20 contract (which you can ensure if you go to registerToken and search for VOC - color 4, ERC20 token.
That's why input in Transfer tokens section have 0 in it.
I've deposited a single TING token to your address.
Now, in order to reproduce the "bug" you will need:

  • select a TING token from the dropdown next to input in Make a deposit section (I know UI is a bit weird on this)
  • observe that second input (in Transfer tokens) section still has empty placeholder, where it should say Token id to transfer

Copy link
Member

@troggy troggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Antd version we use doesn't support placeholder for Select component.

Merged with minor addition here 1e01736

@troggy troggy closed this Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet: wrong placeholder for NFT transfer input field
3 participants