Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tool for deploying - Suggestion #5

Closed
DistributedDoge opened this issue Apr 9, 2019 · 0 comments
Closed

New tool for deploying - Suggestion #5

DistributedDoge opened this issue Apr 9, 2019 · 0 comments

Comments

@DistributedDoge
Copy link
Collaborator

DistributedDoge commented Apr 9, 2019

I think the tools/hashLockCondition.js script made to illustrate adding spending condition (SC) really helps newcomers to Leap (like me!) to work with the concept. All I have to do in order to deploy and test SC is write proper solidity and run the script.

In my opininon it might be worthwile to create a more generalized script that takes arguments in form: deploy.js <condition_name> and then 1) deploys SC of a given <condition_name> to RPC_URL 2) waits for a transaction to see what SC does once it gets some tokens just like your tool.

Since different spending conditions have different parameters (e.g. address constant tokenAddr = 0x1111111111111111111111111111111111111111;) I think it is the developer that should set those on compile time, rather then ninja-editing it like hashLockCondition.js does, but both approaches have its merit.

EDIT: Closed in favor of #15 which takes the proposal further and is much better specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant